Skip to content

P2321R2: views::adjacent_transform, views::pairwise_transform#3546

Merged
StephanTLavavej merged 14 commits intomicrosoft:mainfrom
JMazurkiewicz:adjacent_transform
Mar 17, 2023
Merged

P2321R2: views::adjacent_transform, views::pairwise_transform#3546
StephanTLavavej merged 14 commits intomicrosoft:mainfrom
JMazurkiewicz:adjacent_transform

Conversation

@JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Mar 7, 2023 •
edited
Loading

Closes #2252. Implemented features:

TODO
  • Reduce and report Clang bug marked in the code with LLVM-?. Current repro: 
    #include <ranges>

auto sum = [](auto... vals) { return (vals + ...); };
int vals[] = {1, 2, 3, 4, 5};
auto v = std::views::adjacent_transform<3>(vals, sum);
    There is no need to report this bug, it's been fixed in Clang 16: https://godbolt.org/z/815f371Wc.
  • Reduce and report MSVC bug: _Invoke_result_with_repeated_type_impl had to be implemented as a recursive template (using index sequence caused ICE). See DevCom-10302378,
  • More tests.

@JMazurkiewicz JMazurkiewicz changed the title Adjacent transform P2321R2: views::adjacent_transform, views::pairwise_transform Mar 7, 2023
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature labels Mar 7, 2023
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review March 7, 2023 15:28
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 7, 2023 15:28
@JMazurkiewicz

This comment was marked as outdated.

Sign in to view
@fsb4000

This comment was marked as resolved.

Sign in to view
@JMazurkiewicz JMazurkiewicz mentioned this pull request Mar 7, 2023
Open
34 tasks
StephanTLavavej
StephanTLavavej reviewed Mar 8, 2023
View reviewed changes
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
frederick-vs-ja
frederick-vs-ja reviewed Mar 8, 2023
View reviewed changes
@JMazurkiewicz

This comment was marked as resolved.

Sign in to view
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
strega-nil-ms
strega-nil-ms approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor request; will push changes.

never mind.

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 16, 2023

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 56a65e0 into microsoft:main Mar 17, 2023
@StephanTLavavej
Copy link
Member

StephanTLavavej commented Mar 17, 2023

Thanks to you, @cpplearner, and @tylerbrawl, the zip paper is now complete! Thank you all!

😻 🤐 🚀

@JMazurkiewicz JMazurkiewicz deleted the adjacent_transform branch March 17, 2023 08:47
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

cxx23 C++23 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

P2321R2 zip

5 participants

@JMazurkiewicz @fsb4000 @StephanTLavavej @frederick-vs-ja @strega-nil-ms